Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment/enum and concrete types for variable products #14648

Closed
wants to merge 6 commits into from
Closed

Experiment/enum and concrete types for variable products #14648

wants to merge 6 commits into from

Conversation

joshheald
Copy link
Contributor

Closes: #

Description

Steps to reproduce

Testing information

Screenshots

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@joshheald
Add POSItem enum to contain item types
9b85b5b
@joshheald
Add variable parent products
440a8f2
@joshheald
Add variable products and service (but not used yet)
315e901
@joshheald
Showing variations when tapped
d9c2ccd
@joshheald
Kind-of working variation display
b291e8b 
This uses a flat ItemListState, which could show root or child sets of items.

There’s an opportunity to use this in a NavigationStack, however we can’t do that while POS is presented _within_ a navigation stack. That’s a bit of a roadblock to properly animating changes, unless we reimplement it :grimace:

There are issues here (hence “kind-of”). Sometimes when opening a variation, especially just after loading or refreshing the main list, it sometimes shows the main list again not the variations. I’ve not explored why, but I suspect there’s some race condition :/
@joshheald
Allow variations to be ordered
aeebd46
@dangermattic
Copy link
Collaborator

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14648-aeebd46
Version21.2
Bundle IDcom.automattic.alpha.woocommerce
Commitaeebd46
App Center BuildWooCommerce - Prototype Builds #12065
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@joshheald joshheald closed this Jan 20, 2025
@joshheald joshheald deleted the experiment/enum-and-concrete-types-for-variable-products branch January 20, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshheald @dangermattic @wpmobilebot